Make nullifierKeyCommitment in Object not optional #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the optional nature of the nullifierKeyCommitment field in the Object structure, making it a required field with a default value. The change simplifies the codebase by eliminating the need to handle none cases since they always corresponded to the universal key commitment default value anyway.
Key changes:
- Changed
nullifierKeyCommitmentfromOption Anoma.NullifierKeyCommitmenttoAnoma.NullifierKeyCommitment := default - Removed the helper function
Object.nullifierKeyCommitment!that was used to unwrap the optional value - Updated all usage sites to directly access the field instead of using the helper function
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AVM/Object.lean | Modified the Object structure to make nullifierKeyCommitment non-optional with default value and removed the helper function |
| Apps/UniversalCounter.lean | Removed explicit assignment of none to nullifierKeyCommitment in toObject function |
| AVM/Logic.lean | Updated field access to use direct field reference instead of helper function |
janmasrovira
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nonevalue always corresponded to thedefaultvalue of NullifierKeyCommitment (universal key commitment) anyway.