Dummy Resource refactor #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors dummy resource functionality by extracting it into a dedicated module and corrects universe level annotations in the Resource module. The changes improve code organization by consolidating dummy resource-related functions and fix type-level issues with universe polymorphism.
- Moves
dummyResourcefunction and related utilities to a new dedicated moduleAVM/Action/DummyResource.lean - Fixes universe level annotations in
Anoma/Resource.leanstructures to properly handle polymorphism - Updates all references to use the new module location and improved helper functions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Anoma/Resource.lean | Adds explicit universe level annotations to Resource-related structures |
| AVM/Logic.lean | Removes dummy resource definition and updates filter logic to use new module |
| AVM/Intent/Translation.lean | Updates references to use Action.dummyResource from new module |
| AVM/Action/DummyResource.lean | New module containing dummy resource definition and related utility functions |
Comments suppressed due to low confidence (1)
806040f to
4022f66
Compare
janmasrovira
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dummyResourceand related functions toAction/DummyResource.leanAnoma.Resource