Allow functions to construct new objects and specify which selves are destroyed/consumed #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83684d2 to
8182c61
Compare
8182c61 to
38ebfc5
Compare
6b28582 to
4f1f250
Compare
lukaszcz
reviewed
Jul 28, 2025
AVM/Ecosystem/Member.lean
Outdated
| deriving BEq | ||
|
|
||
| structure FunctionResult {lab : Ecosystem.Label} (functionId : lab.FunctionId) : Type (u + 1) where | ||
| /-- List of created objects -/ |
Collaborator
There was a problem hiding this comment.
Should we change the comment when we changed the field name? Maybe we should explain what "assembled" means.
Collaborator
Author
There was a problem hiding this comment.
comment added
lukaszcz
reviewed
Jul 28, 2025
| def splitsExact (lst : List A) (lengths : List Nat) : Option (SplitsType A lengths) := | ||
| match splits lst lengths with | ||
| | .some (_, []) => none | ||
| | _ => none |
Collaborator
There was a problem hiding this comment.
Something is wrong here. The result of splitsExact is always none.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the function system to support object construction and destruction, extending beyond just assembly/disassembly operations. It introduces explicit control over how function arguments are handled - whether they should be destroyed (with automatic ephemeral resource balancing) or disassembled (requiring manual balancing).
Key changes include:
- Functions can now construct new objects in addition to assembling existing ones
- Functions specify destruction/disassembly behavior for each object argument
- Enhanced the KudosBank example with a Check class and related transfer operations
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Apps/KudosBank.lean | Adds Check class with transfer functionality and IssueCheck/DepositCheck functions demonstrating new construction/destruction patterns |
| AVM/Ecosystem/Member.lean | Introduces DeconstructionKind enum and updates FunctionResult to support constructed objects and argument deconstruction specification |
| AVM/Action.lean | Updates action creation to include memberData parameter and adds balance methods for constructed/destroyed objects |
| AVM/Ecosystem/AppData.lean | Adds FunctionData structure and memberData field to AppData for storing function metadata |
| AVM/Ecosystem/Translation.lean | Updates function logic and action creation to handle constructed objects and argument deconstruction tracking |
17cc43b to
d55a780
Compare
lukaszcz
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the model:
Apps:
I've extended the kudos bank example with a new class
Check. I've added two functions to the ecosystem:IssueCheck. It subtracts some amount from your bank account and creates a new check for that amount.DepositCheck. It destroys a check and adds its amount to your bank account.