Remove the NullifierKeyCommitment from the AVM layer #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
janmasrovira
commented
Jul 29, 2025
- Closes Don't expose nullifierKeyCommitment directly to the user #37
Merged
lukaszcz
reviewed
Aug 3, 2025
lukaszcz
reviewed
Aug 3, 2025
AVM/Class/Translation.lean
Outdated
| { object := {newObj with nullifierKeyCommitment := Anoma.NullifierKeyCommitment.universal} | ||
| { object := newObj | ||
| ephemeral := true | ||
| key := Anoma.NullifierKey.universal } |
Collaborator
There was a problem hiding this comment.
Shouldn't we remove the key field from ConsumableObject if it's always universal anyway?
Collaborator
There was a problem hiding this comment.
Not done for ConsumableObject, only for Object
Collaborator
Author
There was a problem hiding this comment.
I've removed the key field from ConsumableObjects and replaced all references to Universal
lukaszcz
previously approved these changes
Aug 4, 2025
lukaszcz
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.