Nested calls #81
Merged
Nested calls #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for nested calls in the AVM system by adding complex method bodies that can contain sequences of operations including constructor calls, destructor calls, method calls, and object fetches. The changes enable method bodies to perform multiple operations rather than just returning a single result. Object fetches within a body retrieve the value at method entrance rather than tracking intermediate changes.
Key changes:
- Introduces
Class.Member.Bodydata structure representing sequences of operations in class member bodies - Refactors class definitions and translation to support complex bodies instead of simple return values
- Updates the Task system to handle object fetching and object ID generation
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| AVM/Class/Member/Body.lean | Defines the new inductive type for representing method body sequences |
| AVM/Task/Parameters.lean | New parameter system supporting both object fetching and ID generation |
| Apps/TwoCounter.lean | New example app demonstrating nested calls with mutual counter increment |
| AVM/Ecosystem.lean, AVM/Ecosystem/Label.lean | New ecosystem abstraction for managing collections of classes |
| AVM/Class.lean, AVM/Class/Member.lean | Updated class and member definitions to use ecosystem labels and complex bodies |
| AVM/Class/Translation.lean | Major refactoring to handle complex body translation |
| Apps/*.lean | Updated existing apps to work with new ecosystem-based structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Jan Mas Rovira <[email protected]>
janmasrovira
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class.Member.Bodydata structure which represents the body of a class member (constructor, destructor, method). The body is a sequence of statements:TwoCounterobject has references (ObjectId) to twoCounterobjects. There is a mutual increment (incrementBoth) method which fetches the values of counters and calls Counter.increment on the counter ids with increment value dependent on counter values.