Typed object references in Applib #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2d6f1f to
00fd376
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces typed object references to the Applib framework, replacing raw ObjectId usage with type-safe Reference wrappers. The main purpose is to provide compile-time type checking for object references in user applications.
- Introduces a generic
Referencetype that wrapsObjectIdwith type information - Updates
ProgramAPI to support typed references alongside existingObjectId-based methods - Modifies the TwoCounter example to demonstrate usage of typed references
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Applib/Surface/Reference.lean |
Defines the new Reference type with type parameter and TypeRep instance |
Applib/Surface/Program.lean |
Adds typed reference variants of program operations (destroy, call, fetch) |
Applib/Surface.lean |
Imports the new Reference module |
Apps/TwoCounter.lean |
Updates example to use Reference Counter instead of raw ObjectId |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
janmasrovira
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Objwhich represents a typed reference to an Object. This is just a typed wrapper overObjectId, allowing the type-checking of references in user apps. The user-facingProgramstatements are adjusted to operate on typed references instead of raw object ids.