Refactor and simplify AVM.Program and surface program syntax #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c6c0b3 to
5909de3
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the AVM.Program module by simplifying its structure and moving parameter definitions from Task to Program. The main change replaces a complex parameter-threaded program structure with a simpler direct representation that eliminates intermediate parameter handling.
- Simplifies
Programby removing parameter threading and complex conversion functions - Moves
Task.ParameterstoProgram.Parametersand updates all references - Updates syntax macros to generate simpler program representations
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Tests/Applib/Surface/Program/Syntax.lean | Updates test syntax to use simplified call format without class names |
| Apps/TwoCounter.lean | Updates method call syntax to match new simplified format |
| Applib/Surface/Program/Syntax.lean | Simplifies macro rules to generate direct program calls instead of parameter-threaded versions |
| Applib/Surface/Program.lean | Major refactor removing parameter threading and complex conversion logic |
| Applib/Surface/Member.lean | Updates return statement to use simplified syntax |
| AVM/Task/Translation.lean | Updates reference from Task.Parameters to Program.Parameters |
| AVM/Task/Parameters.lean | File deleted as parameters moved to Program module |
| AVM/Task.lean | Updates import and references to use Program.Parameters |
| AVM/Program/Parameters.lean | New file containing moved parameter definitions from Task |
| AVM/Program.lean | Simplifies Program structure removing parameter threading |
| AVM/Class/Translation.lean | Updates to work with simplified Program structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
janmasrovira
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVM.Program.AVM.Task.ParameterstoAVM.Program.Parameters.