Functions #88
Merged
Functions #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces function support to the program syntax by adding an "invoke" operation alongside refactoring the program representation to track size at the type level. The changes enable calling user-defined functions within the domain-specific language.
- Adds
invokesyntax and semantics for function calls - Refactors program representation to be size-indexed (
Program.Sized) - Updates macro rules to use a new intermediate syntax (
Ξ) for size tracking
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Applib/Surface/Program/Syntax.lean | Converts example to use def mutualIncrement function and demonstrates invoke usage |
| Applib/Surface/Program/Syntax.lean | Adds invoke syntax rules and refactors macro expansion to use size-indexed programs |
| Applib/Surface/Program.lean | Implements size-indexed program type and invoke operations with lifting functions |
| AVM/Program/Parameters.lean | Adds Nonempty derivation to Program.Parameters |
| AVM/Program.lean | Refactors to size-indexed programs and implements invoke semantics with parameter handling |
| AVM/Class/Translation.lean | Updates program task generation to handle size-indexed programs and invoke operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
janmasrovira
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invokeprogram constructor.