If-then-else and match syntax #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2bc8cb to
6132f92
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements conditional and pattern matching syntax for Applib Programs, adding if-then-else, if-then, and match constructs to the domain-specific language.
- Adds syntax definitions for conditional statements (
if-then-else,if-then) and pattern matching (match) - Implements macro rules to translate the new syntax into underlying Program operations
- Provides comprehensive test cases demonstrating the new conditional and pattern matching capabilities
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Applib/Surface/Program/Syntax.lean | Core implementation adding syntax rules and macro expansions for conditionals and pattern matching |
| Tests/Applib/Surface/Program/Syntax.lean | Test examples demonstrating the new if-then-else and match syntax functionality |
Comments suppressed due to low confidence (1)
Applib/Surface/Program/Syntax.lean:1
- The macro rule expects three arguments but the corresponding syntax definition on line 23 only captures 'ident term'. Similar to the call syntax, this expects method, object, and arguments but only two are provided in the syntax.
import Applib.Surface.Program
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
janmasrovira
approved these changes
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if-then-else,if-thenandmatchsyntax in Applib Programs.