Tracking object changes in programs #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9d21ff to
9d8334c
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements tracking of changes to objects resulting from method calls inside programs, enabling correct compilation of programs with multiple method calls on the same object. The implementation introduces an intermediate Tasks type that represents a sequence of tasks with intervening object fetches and random value generations, which mimics more closely the structure of AVM programs than a single Task.
- Introduces the
Taskstype as an intermediate representation betweenAVM.ProgramandTask - Implements object change tracking through adjustment functions that apply modifications from program execution
- Replaces the previous list-based task composition with a more structured approach that properly handles object state changes
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Apps/KudosBank.lean | Adds Inhabited derivation to data structures |
| AVM/Tasks.lean | Introduces new Tasks type and composition functions |
| AVM/Task.lean | Simplifies Task by removing list composition methods and adding helper functions |
| AVM/Program/Translation.lean | Updates compilation to use new Tasks-based approach |
| AVM/Program/Parameters.lean | Replaces genId with rand, adds Inhabited instance and helper functions |
| AVM/Program.lean | Renames returnValue to value and improves documentation |
| AVM/Object/Created.lean | Adds rand field to CreatedObject and updates constructor |
| AVM/Object.lean | Adds Inhabited instance for ObjectData and Object |
| AVM/Class/Translation/Tasks.lean | Implements task creation with object change tracking |
| AVM/Class/Translation/Messages.lean | Extracts message creation functions |
| AVM/Class/Translation/Logics.lean | Extracts logic creation functions |
| AVM/Class/Translation.lean | Simplifies by importing modularized components |
| AVM/Class/Label.lean | Adds Inhabited constraint for private fields |
| AVM/Action.lean | Adds object conversion methods and updates balance functions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
janmasrovira
approved these changes
Sep 8, 2025
lukaszcz
added a commit
that referenced
this pull request
Sep 16, 2025
- I forgot to change this in #95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taskstype which represents a sequence of tasks with intervening object fetches and random value generations. TheTaskstype mimics more closely the structure of AVM programs than a singleTask.AVM.Programis compiled toTaskswhich are then composed into a singleTask. The composition ofTaskscollects and lifts out the parameters of all subtasks.