Make Resource Logic references explicit #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes Resource Logic references explicit by introducing a LogicRef type and adding it as a field to Anoma.Resource. This change allows for explicit validation of resource logic reference equality instead of relying on comments indicating where such checks should be performed.
Key changes:
- Introduces
LogicRefstructure with string-based reference identification - Refactors
Logic.Argsstructure to separate data types and move logic definitions to a dedicated module - Adds explicit resource logic reference checks throughout the codebase, replacing previous comment placeholders
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Anoma/Resource.lean | Adds LogicRef structure and logicRef field to Resource, removes old logic structures |
| Anoma/Logic.lean | New file containing restructured Logic.Args and Logic definitions |
| Anoma.lean | Adds import for new Logic module |
| AVM/Object.lean | Updates resource conversion methods to handle logicRef field |
| AVM/Message.lean | Adds logicRef field to messages and implements reference validation |
| AVM/Logic.lean | Updates resource validation to use explicit logic reference checks |
| AVM/Class/Translation/Messages.lean | Updates message creation to include logic references |
| AVM/Class/Translation/Logics.lean | Refactors logic definitions to use new Logic structure with references |
| AVM/Class/Member.lean | Minor type annotation update for Constructor |
| AVM/Class/Label.lean | Adds logicRef method to Label structure |
| AVM/Class.lean | Updates Logic.Args type alias |
| AVM/Action/DummyResource.lean | Restructures dummy resource logic to use new Logic structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
janmasrovira
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logicReffield toAnoma.ResourceLogic.Argstype