Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds two new syntax features to the Applib surface program language: let bindings for local variable declaration and bang (!) syntax for reinterpreting arbitrary Lean terms as programs.
- Adds
letbinding syntax with optional type annotations for local variable declarations within programs - Introduces
!(bang) syntax to allow embedding arbitrary Lean terms directly into program contexts - Updates syntax rules and macro expansions to support these new constructs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Applib/Surface/Program/Syntax.lean | Implements core syntax definitions and macro rules for let bindings and bang syntax |
| Tests/Applib/Surface/Program/Syntax.lean | Adds comprehensive test cases demonstrating the new let and bang syntax features |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
janmasrovira
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
! termsyntax.