Remove TypedObjectId and AnObject #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
approved these changes
Sep 9, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to remove the TypedObjectId type and replace it with a cleaner approach using a separate classLabel parameter in fetch operations. Additionally, it removes the unused AnObject type from the Surface Object module.
- Replaces
TypedObjectIdwith explicitclassLabelparameter in fetch constructors - Removes unused
AnObjecttype and related helper functions - Updates all fetch operations to use the new parameter structure
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| AVM/Object.lean | Removes TypedObjectId structure definition |
| Applib/Surface/Object.lean | Removes unused AnObject type and related functions |
| AVM/Program.lean | Updates fetch constructor to use separate classLabel parameter |
| AVM/Program/Parameters.lean | Updates Parameters.fetch to use new parameter structure |
| AVM/Tasks.lean | Updates Tasks.fetch to use new parameter structure |
| AVM/Task.lean | Updates Task.absorbFetch to use new parameter structure |
| AVM/Task/Translation.lean | Updates parameter resolution to use new structure |
| AVM/Class/Translation/Tasks.lean | Updates fetch calls to use new parameter structure |
| Applib/Surface/Program.lean | Updates toAVM translation to use new parameter structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypedObjectIdin favour of having a separate field with the class label in thefetchconstructors. This makes the handling of object ids more uniform.AnObjecttype fromApplib.Surface.Object