refactor: object resource logics #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors object resource logic by moving logic references from ecosystem-level to class-level, simplifying the architecture and ensuring class invariants are checked for multi-method messages. The changes consolidate duplicated functionality between class and ecosystem logics.
- Moved logic references from ecosystem labels to class labels
- Updated object resource conversion to use class-based logic references
- Removed ecosystem-level logic functions and consolidated logic handling at the class level
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| AVM/Object.lean | Updated object-to-resource conversion to use class logic references |
| AVM/Logic.lean | Modified resource value comparison to use class-based logic references |
| AVM/Ecosystem/Label/Base.lean | Removed ecosystem-level logic reference function |
| AVM/Class/Translation/Logics.lean | Refactored class logic to handle multi-methods and removed ecosystem logic |
| AVM/Class/Label.lean | Added class-level logic reference function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
janmasrovira
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ecosystem and class logics were confusing and overcomplicated, duplicating functionality. Also, the class invariant was not checked when the received message corresponded to a multi-method.
Now, the RLs for objects are again associated with the class, but the check also works for multi-methods in the same ecosystem.