fix: include ephemeral object resources in recipients of multi-method messages #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the message recipient handling in the AVM system to include ephemeral object resources in multi-method message recipients. The change addresses an issue where ephemeral objects were not properly considered as recipients, which caused incorrect class logic validation.
- Changes the recipients field from a fixed-size vector to a dynamic list structure
- Updates multi-method message generation to include both existing recipients and ephemeral objects
- Modifies all message creation functions to use the new list-based recipient format
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| AVM/Message/Base.lean | Changes recipients field from List.Vector to List ObjectId and updates default message |
| AVM/Ecosystem/Label/Base.lean | Adds documentation comment for numObjectArgs function |
| AVM/Class/Translation/Tasks.lean | Updates mkMessage function signatures to accept additional parameters for ephemeral object handling |
| AVM/Class/Translation/Messages.lean | Converts all message creation functions from Vector.singleton to list syntax and adds ephemeral objects to multi-method recipients |
| AVM/Class/Translation/Logics.lean | Updates logic validation to work with the new list-based recipients structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
janmasrovira
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not including them as recipients resulted in incorrect class logic - it checked if every consumed resource is a recipient. For the constructor message, the created object is the recipient, so it's consistent now.