fix: authorization #130
Merged
fix: authorization #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e5e2e0 to
9ac5111
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR redesigns the authorization system in the GOOSE framework by implementing message-level signatures. The key changes move from storing individual signatures to storing functions that generate signature lists, and simplify the signature checking process.
- Refactored authorization to validate entire message content
- Replaced static signature storage with dynamic signature generation functions
- Simplified signature structure and verification logic
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
Tests/Applib/Surface/Program/Syntax.lean |
Updated PublicKey type reference to use AVM.PublicKey |
SUMMARY.md |
Updated documentation to reflect new authorization model with message-level signatures |
Apps/OwnedCounter.lean |
Converted to new signature API and updated invariant function signatures |
Apps/KudosBank.lean |
Updated signature handling and removed signature ID enums |
Apps/Kudos.lean |
Migrated to message-based signature checking |
Applib/Surface/Program.lean |
Changed signature parameters from static to function-based |
Applib/Surface/MultiMethod.lean |
Updated multimethod signature handling |
Applib/Surface/Member.lean |
Refactored member signature handling and invariant functions |
AVM/Program.lean |
Updated core program signature definitions |
AVM/Message/Data.lean |
New file defining message data structure |
AVM/Message/Base.lean |
Restructured message with separate data and signatures |
AVM/Message.lean |
Added checkSignature helper method |
AVM/Logic/Base.lean |
New file with logic reference utilities |
AVM/Logic.lean |
Updated imports |
AVM/Ecosystem/Member.lean |
Updated multimethod invariant signature |
AVM/Ecosystem/Label/Base.lean |
Removed signature ID infrastructure |
AVM/Class/Translation/Tasks.lean |
Updated task signature parameters |
AVM/Class/Translation/Messages.lean |
Restructured message creation |
AVM/Class/Translation/Logics.lean |
Updated logic validation for new signature model |
AVM/Class/Member.lean |
Updated member invariant signatures |
AVM/Class/Label.lean |
Removed signature ID definitions |
AVM/Authorization.lean |
Simplified signature structure and checking |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
janmasrovira
previously approved these changes
Oct 22, 2025
4b831dd to
ec4ced7
Compare
janmasrovira
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.