Refactor TypeRep instances for parameterised types #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors TypeRep instances to use Rep.composite for parameterised types instead of embedding parameters in the atomic name, and updates related mapping syntax in intent translation.
- Extend the doc comment for
Rep.atomicto mention encoding parameter values in the name. - Change
hasTypeRepinstances inAVM.Object,AVM.Object.Consumable, andAVM.Class.AppDatato useRep.composite. - Update list‐mapping calls in
AVM.Intent.Translationto use the.mapmethod and pipeline syntax.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Prelude/TypeRep.lean | Clarify Rep.atomic comment |
| AVM/Object/Consumable.lean | Switch from Rep.atomic with name suffix to Rep.composite |
| AVM/Object.lean | Switch from Rep.atomic with name suffix to Rep.composite |
| AVM/Class/AppData.lean | Switch from Rep.atomic with name suffix to Rep.composite |
| AVM/Intent/Translation.lean | Replace List.map calls with .map and pipeline (` |
Comments suppressed due to low confidence (3)
Prelude/TypeRep.lean:9
- [nitpick] The doc for
Rep.atomicis a bit ambiguous about its intended use for parameterised types. Consider clarifying that atomic is primarily for parameterless types and only encodes parameters in the name when absolutely necessary, with composite preferred for structured parameters.
identified by the type name) or parameter values (stored in the name). -/
Prelude/TypeRep.lean:11
- [nitpick] It may help to expand this comment to note that
Rep.compositestores each parameter in theparamslist, contrasting it with atomic’s name‐based encoding.
/-- `Rep.composite` is used for parameterised data types -/
AVM/Intent/Translation.lean:37
- [nitpick] There's a mix of free‐function
List.mapand the.mapmethod style in this file and others. For consistency and readability, consider standardizing on one mapping style project-wide.
match provided.map (fun p => p.toConsumable false key |>.consume) |>.getSome with
d95f167 to
a87343b
Compare
janmasrovira
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.