fix(pritunl_user): improve resilience to null or missing user parameters #10955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Collaborator
felixfontein
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Can you add a changelog fragment? Thanks.
changelogs/fragments/10955-pritunl_user-null-missing-params.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Collaborator
|
If nobody objects, I'll merge this in a few days. |
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #11013 🤖 @patchback |
Collaborator
|
@david-m-jenkins thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
…ers (#10955) * fix(pritunl_user): improve resilience to null or missing user parameters * added changelog fragment - 10955 * standardize 10955 changelog fragment content Co-authored-by: Felix Fontein <[email protected]> * simplify user params comparison Co-authored-by: Felix Fontein <[email protected]> * simplify list fetch Co-authored-by: Felix Fontein <[email protected]> * simplify remote value retrieval Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: djenkins <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit e84f59a)
Backport to stable-11: 💚 backport PR created✅ Backport PR branch: Backported as #11014 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
…ers (#10955) * fix(pritunl_user): improve resilience to null or missing user parameters * added changelog fragment - 10955 * standardize 10955 changelog fragment content Co-authored-by: Felix Fontein <[email protected]> * simplify user params comparison Co-authored-by: Felix Fontein <[email protected]> * simplify list fetch Co-authored-by: Felix Fontein <[email protected]> * simplify remote value retrieval Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: djenkins <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit e84f59a)
felixfontein
added a commit
that referenced
this pull request
Oct 29, 2025
…esilience to null or missing user parameters (#11014) fix(pritunl_user): improve resilience to null or missing user parameters (#10955) * fix(pritunl_user): improve resilience to null or missing user parameters * added changelog fragment - 10955 * standardize 10955 changelog fragment content * simplify user params comparison * simplify list fetch * simplify remote value retrieval --------- (cherry picked from commit e84f59a) Co-authored-by: David Jenkins <[email protected]> Co-authored-by: djenkins <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
felixfontein
added a commit
that referenced
this pull request
Oct 29, 2025
…esilience to null or missing user parameters (#11013) fix(pritunl_user): improve resilience to null or missing user parameters (#10955) * fix(pritunl_user): improve resilience to null or missing user parameters * added changelog fragment - 10955 * standardize 10955 changelog fragment content * simplify user params comparison * simplify list fetch * simplify remote value retrieval --------- (cherry picked from commit e84f59a) Co-authored-by: David Jenkins <[email protected]> Co-authored-by: djenkins <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #10954
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION