Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update regex match string for parse_iostype #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2020
Merged

update regex match string for parse_iostype #69

merged 1 commit into from
Aug 10, 2020

Conversation

@poroping
Copy link
Contributor

@poroping poroping commented Jun 5, 2020 •
edited by Qalthos
Loading

SUMMARY

Update regex to look for ' IOS-XE ' in show version output. Previous regex was unable to match older IOS-XE versions (Version 03.04.02.SG on cat4500 for example).

Closes #71

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_facts

ADDITIONAL INFORMATION

IOS-XE does not appear in any IOS show version outputs I have tested. Set the regex to '\sIOS-XE\s' as whitespace characters should not be allowed in hostname in case someone is weird and does that.

Previous regex does not match:

Cisco IOS Software, IOS-XE Software, Catalyst 4500 L3 Switch Software (cat4500e-UNIVERSALK9-M), Version 03.04.02.SG RELEASE SOFTWARE (fc1)
Technical Support: http://www.cisco.com/techsupport
Copyright (c) 1986-2013 by Cisco Systems, Inc.
Compiled Thu 05-Sep-13 19:06 by prod_rel_team



Cisco IOS-XE software, Copyright (c) 2005-2010, 2012 by cisco Systems, Inc.
All rights reserved.  Certain components of Cisco IOS-XE software are
licensed under the GNU General Public License ("GPL") Version 2.0.  The
software code licensed under GPL Version 2.0 is free software that comes
with ABSOLUTELY NO WARRANTY.  You can redistribute and/or modify such
GPL code under the terms of GPL Version 2.0.  For more details, see the
documentation or "License Notice" file accompanying the IOS-XE software,
or the applicable URL provided on the flyer accompanying the IOS-XE
software.



ROM: 15.0(1r)SG10
xxx uptime is 1 year, 41 weeks, 5 days, 10 hours, 33 minutes
System returned to ROM by reload
System restarted at 06:10:09 UTC Sat Aug 18 2018
Running default software
Jawa Revision 2, Winter Revision 0x0.0x41

Last reload reason: Reload command



This product contains cryptographic features and is subject to United
States and local country laws governing import, export, transfer and
use. Delivery of Cisco cryptographic products does not imply
third-party authority to import, export, distribute or use encryption.
Importers, exporters, distributors and users are responsible for
compliance with U.S. and local country laws. By using this product you
agree to comply with applicable laws and regulations. If you are unable
to comply with U.S. and local laws, return this product immediately.

A summary of U.S. laws governing Cisco cryptographic products may be found at:
http://www.cisco.com/wwl/export/crypto/tool/stqrg.html

If you require further assistance please contact us by sending email to
[email protected].


License Information for 'WS-C4500X-16'
    License Level: entservices   Type: Permanent
    Next reboot license Level: entservices

cisco WS-C4500X-16 (MPC8572) processor (revision 9) with 4194304K/20480K bytes of memory.
Processor board ID xxx
MPC8572 CPU at 1.5GHz, Cisco Catalyst 4500X
Last reset from Reload
23 Virtual Ethernet interfaces
24 Ten Gigabit Ethernet interfaces
511K bytes of non-volatile configuration memory.

Configuration register is 0x2101

@poroping
update regex match string for parse_iostype
51e8931 
Previous regex was unable to match older IOS-XE versions (Version 03.04.02.SG on cat4500 for example)
@poroping poroping mentioned this pull request Jun 9, 2020
Closed
@Qalthos Qalthos requested a review from justjais June 10, 2020 12:52
@justjais
Copy link
Member

justjais commented Jun 22, 2020

@poroping can u plz fix the test failures. Thanks!

@pabelanger pabelanger changed the base branch from master to main July 7, 2020 14:37
@poroping
Copy link
Contributor Author

poroping commented Jul 27, 2020

@poroping can u plz fix the test failures. Thanks!

Hey soz the delay. I have no idea why these tests are failing. I don't think it's the single regex expression I changed.

@justjais
Copy link
Member

justjais commented Jul 27, 2020

recheck

@justjais justjais added the mergeit Gate PR in Zuul CI label Jul 27, 2020
@justjais
Copy link
Member

justjais commented Jul 27, 2020

@poroping guess there was some issue from test side, it passed now and changes also LGTM.

@pabelanger pabelanger added mergeit Gate PR in Zuul CI and removed mergeit Gate PR in Zuul CI labels Aug 10, 2020
@ansible-zuul ansible-zuul bot merged commit abe0af2 into ansible-collections:main Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@justjais justjais justjais approved these changes

@RoxyLovesToCode RoxyLovesToCode RoxyLovesToCode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mergeit Gate PR in Zuul CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ios modules not correctly diferentiating between IOS and IOS-XE

4 participants

@poroping @justjais @RoxyLovesToCode @pabelanger