Add the become flag and become_user var to the callback plugin #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damionparry
commented
Aug 27, 2024
- Enables propagating the become flag and become user to external logs allowing the use of become to be audited
* Enables propagating the become flag and become user to external logs allowing the use of become to be audited
Signed-off-by: [email protected] <[email protected]>
Add callback integration test
|
@ansible/executor is it possible to get some traction on this PR? It's been awaiting a review for a long time now Thanks |
Tompage1994
reviewed
Apr 2, 2025
Co-authored-by: Tom Page <[email protected]>
Shrews
requested changes
Apr 2, 2025
Tompage1994
reviewed
Apr 2, 2025
Co-authored-by: Tom Page <[email protected]>
Shrews
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
LGTM. Since this touches the awx_display callback, we have to get approval from someone on the Controller/AWX team since that is a crucial piece to that project.
@AlanCoding Can you or someone from your team have a look at this? Not sure that it needs full testing, but will leave that up to you.
|
Can we get more traction on this again please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.