Fix object-level permission bugs with DAB RBAC system #15284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosterseth
approved these changes
Jun 20, 2024
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
* Fix object-level permission bugs with DAB RBAC system * Fix NT organization change regression * Mark tests to AAP number
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
* Fix object-level permission bugs with DAB RBAC system * Fix NT organization change regression * Mark tests to AAP number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes API bugs when permissions are assigned through the DAB RBAC API
AAP-25493
AAP-25506
Ping @PabloHiro
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
I'm separating these from other fixes, as this is a really specific category of bug, and the easiest to fix, by far. This is just simple logic that needed to be updated in the "access" python logic to work with either system. No migration or data integrity issues are involved, evaluations were just giving the wrong answer in cases.
These wrong answers were almost exclusively due to "new" role content, where the NotificationTemplate object-level role assignments were not possible before, as an example. So it's not surprising that the old logic isn't compatible and I just never looked at it.