-
Notifications
You must be signed in to change notification settings - Fork 665
ansible-navigator as molecule playbook executor #4444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ec21f53 to
92bb22d
Compare
cidrblock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a quick test for navigator? It can use navigator's default EE, but we should make sure it works.
Can you also add some docs someplace explaining the param and that it gives the user the ability to test inside of an EE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the ansible-navigator provisioner alongside the existing ansible-playbook provisioner, allowing users to select the backend through a new backend option in molecule.yml. Key changes include:
- Updating the molecule.yml schema and test fixtures to support a new "backend" configuration.
- Extending ProvisionerData and the ansible backend property to include and manage the new backend option.
- Modifying the bake method in ansible_playbook.py to construct commands based on the selected backend.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/fixtures/integration/test_command/molecule/kubevirt/molecule.yml | Added backend config option comment to show valid options. |
| src/molecule/types.py | Extended ProvisionerData to support a backend option. |
| src/molecule/provisioner/ansible_playbook.py | Updated bake method to handle both ansible-playbook and ansible-navigator backends with error handling. |
| src/molecule/provisioner/ansible.py | Added a new backend property to expose the provisioner’s backend value. |
| src/molecule/data/molecule.json | Updated JSON schema to include the new backend property. |
| src/molecule/config.py | Added a default key for backend in the provisioner configuration. |
|
(added copilot to see it's review) |
…d unit tests for navigator command
6ad0a61 to
499d53b
Compare
96ec72f to
7979f27
Compare
…e Podman and docker not currently available for macOS on Github
|
@cidrblock @Qalthos, I have added an integration test for the case where backend is set to |
|
let's move the backend to |
|
please mark this experimental somewhere |
This would be a new key under |
ff1c366 to
2c410bb
Compare
2c410bb to
2de2a67
Compare
### SUMMARY This PR adds a "backend" option in the molecule.yml file, inside a new root level key "executor". Relevant tests and docs are added in the PR. Follow-up work from #4444 JIRA: [AAP-46691](https://issues.redhat.com/browse/AAP-46691) **Example molecule.yml with ansible-navigator set as playbook executor ->** ``` --- executor: backend: ansible-navigator platforms: - name: localhost provisioner: name: ansible ```
|
All the changes are done in PR: #4457 |
SUMMARY
JIRA: AAP-30868
Closes: #4009
This PR adds
ansible-navigatorprovisioner alongside the existingansible-playbookprovisioner. Introduces abackendoption in the molecule.yml file and modifies ansible-playbook class to handle the selection of the backend.Details -
backendconfig option under the provisioner section. This option allow users to specify either ansible-playbook or ansible-navigator as the backend.