Fix #4408 parallel execution: create parent directory #4458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c01a64b to
828215d
Compare
Contributor
Author
|
Hi @Qalthos when you get a chance, could you please review this fix? |
Qalthos
requested changes
Jun 12, 2025
4e4d3d4 to
ff5a4c4
Compare
d2320c5 to
ff5a4c4
Compare
Qalthos
approved these changes
Jun 12, 2025
Collaborator
|
Amusingly, codecov dropped because we depended on this failing to test the failing path. I think we're fine to keep it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4408
ensure directory path for missing ephimeral directory exists.