Make sure path exist before writing #4472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the directory for a target file exists before writing and refactors the initial “create” step in _run_scenarios to separate shared‐data handling.
- util.py: Add a call to create the parent directory before writing the file.
- base.py: Simplify the shared_data check, add a nested “create” condition, and update lint ignore.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/molecule/util.py | Ensure parent directory exists before writing file content |
| src/molecule/command/base.py | Refactor initial scenario “create” logic and update lint flags |
Comments suppressed due to low confidence (1)
src/molecule/command/base.py:214
- This append should only occur if the subcommand actually ran; indent both this line and the
default.results = []line under the nestedif "create" in ...block to avoid appending or clearing results whencreatewasn’t executed.
scenarios.results.append({"name": default.name, "results": default.results})
cidrblock
approved these changes
Jul 10, 2025
ssbarnea
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.