Fix KeyError command_borders in login and reset commands #4515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove command_borders reference from login.py since login command does not have this CLI parameter available. Add missing command_borders reference to reset.py command_args since it has the CLI parameter but wasn't using it. Fixes ansible#4513
alisonlhart
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the KeyError: 'command_borders' issue reported in #4513.
Changes:
Problem:
The login command was trying to access ctx.params['command_borders'] but this parameter is not available because login uses @options(['host', 'scenario_name_single_with_default']) instead of @common_options() which includes command_borders.
Solution:
Align command_args dictionaries with their actual available CLI parameters:
Fixes #4513