Nested CBOR validation fixes #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This pull request addresses issue #224 by refining the nested CBOR validation logic. The key changes include combining conditional branches for range checks in CBOR and JSON validators, adding detailed handling for embedded CBOR values (both as direct byte strings and within arrays), and introducing tests to cover valid and invalid nested CBOR scenarios.
Changes
| File | Description |
|---|---|
| src/validator/cbor.rs | Simplifies conditional checks, refines embedded CBOR decoding for both byte strings and arrays, and adds tests. |
| src/validator/json.rs | Harmonizes range validation conditions for integer and string values to improve clarity in error handling. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/validator/cbor.rs:1969
- Review the change in tag comparison: the previous cast to u64 ensured type consistency. Verify that removing the cast by using '{ *tag }' does not introduce type mismatches between *tag and *actual_tag.
if { *tag } != *actual_tag {
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #224