Fix inline group parsing #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new subparser is constructed, we must pass in known `groupnames` and `typenames` so that the subparser also knows about them. It's also imperative that the main parser appends all unknown rule identifiers found by the subparser, so we can reparse them later.
|
@anweiss After we merge this, could we make a release? We have a package that we want to publish, but it depends on main (not a version number), so we cannot publish it until |
|
@anweiss Do you plan to make a release? Again, we can't publish to crates.io because crates.io doesn't allow packages depending on a git branch (we are currently depending on main). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new subparser is constructed, we must pass in known
groupnamesandtypenamesso that the subparser also knows about them. It's also imperative that the main parser appends all unknown rule identifiers found by the subparser so we can reparse them later.