feat: make config.testPattern optional #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
rmarescu
commented
Feb 23, 2025
| const runner = new TestRunner(process.cwd(), config); | ||
| await runner.initialize(); | ||
| const success = await runner.runTests(testPattern); | ||
| const success = await runner.execute(config.testPattern); |
There was a problem hiding this comment.
This name better represents what the function does (at the time of calling, is not known yet if there are any tests to be executed yet).
Comment on lines
-73
to
-82
| if (files.length === 0) { | ||
| this.reporter.error( | ||
| "Test Discovery", | ||
| `No test files found matching: ${testPattern}`, | ||
| ); | ||
| this.log.error("No test files found matching", { | ||
| pattern: testPattern, | ||
| }); | ||
| process.exit(1); | ||
| } |
There was a problem hiding this comment.
This is duplicated started on line 375 below.
|
|
||
| private async findTestFiles(pattern?: string): Promise<string[]> { | ||
| this.log.trace("Finding test files", { pattern }); | ||
| const testPattern = pattern || this.config.testPattern || "**/*.test.ts"; |
There was a problem hiding this comment.
Config should be the source of truth of all default values, in conjuction with Zod validation.
| this.browserManager = new BrowserManager(this.config); | ||
| } | ||
|
|
||
| private async findTestFiles(pattern?: string): Promise<string[]> { |
There was a problem hiding this comment.
Once the default value assignment and duplicated logic are removed, there isn't much value having this function.
| describe("Config parsing", () => { | ||
| let baseConfig: ShortestConfig; | ||
|
|
||
| beforeEach(() => { |
There was a problem hiding this comment.
Moved below (not used by with minimal config test)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.testPatternoptional, default to**/*.test.tsWhy