Thanks to visit codestin.com
Credit goes to github.com

Skip to content

perf: Avoid duplicate dirty parent elements to improve performance by 2% #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wang1212 merged 3 commits into from
Jul 21, 2025
Merged

perf: Avoid duplicate dirty parent elements to improve performance by 2% #1968

wang1212 merged 3 commits into from
Jul 21, 2025

Conversation

@Alexzjt
Copy link
Contributor

@Alexzjt Alexzjt commented Jul 18, 2025

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

s2滚动场景下，有大量嵌套的节点会走到dirtyToRoot。排在前面的元素自下而上dirty后，排在后面的元素不需要再给父元素dirty了。

before After
image image

📝 Changelog

Language Changelog
🇺🇸 English Avoid duplicate dirty parent elements to improve performance by 2%
🇨🇳 Chinese 避免重复dirty父级元素提升2%性能

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8bd037f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wang1212
Copy link
Member

wang1212 commented Jul 18, 2025

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 18, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves performance by avoiding redundant dirtying of parent elements. The change terminates the upward traversal in dirtyToRoot if a parent is already marked as dirty. A potential correctness issue was identified where the loop might terminate prematurely, leading to rendering artifacts. The suggested solution involves refining the loop condition to ensure all necessary dirty flags are set.

Alexzjt and others added 2 commits July 18, 2025 14:52
@Alexzjt @gemini-code-assist
perf: accept gemini review
8f28876 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Alexzjt
refactor: 修复eslint
8bd037f
@wang1212 wang1212 merged commit 433cc43 into master Jul 21, 2025
4 checks passed
@wang1212 wang1212 deleted the perf/dirty branch July 21, 2025 11:09
wang1212 added a commit that referenced this pull request Jul 28, 2025
@wang1212
revert: fix element attribute update exception #1968
a957c89
wang1212 added a commit that referenced this pull request Jul 30, 2025
@wang1212 @Alexzjt
@gemini-code-assist @github-actions
Release (#1979)
6369e6e 
* fix: prevent NaN in transform calculations when scale is 0 (#1971)

* fix: prevent NaN in transform calculations when scale is 0

- Add MIN_SCALE constant to avoid zero scaling
- Update scale transform functions to enforce minimum scale value
- Add test case for scale(0) transform
- Add demo example with scale(0) transform

* chore: add changeset

* refactor: extract scale clamping logic into reusable function

- Add clampScale helper function to avoid code duplication
- Replace repeated Math.max(item, MIN_SCALE) calls with clampScale
- Maintain same behavior while improving code maintainability

* chore: add changeset

* perf: use charWidthCache to improve performance by 1.5% (#1978)

* perf: 避免重复dirty父级元素提升2%性能

* perf: accept gemini review

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* refactor: 修复eslint

* perf: use charWidthCache to improve performance by 1.5%

* refactor: 修复评审意见

* refactor: 修复评审意见

* refactor: 使用LRU

* refactor: 使用LRU

* chore: add changeset

---------

Co-authored-by: huiyu.zjt <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: wang1212 <[email protected]>

* revert: fix element attribute update exception #1968

* chore(release): bump version (#1977)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: huiyu.zjt <[email protected]>
Co-authored-by: huiyu.zjt <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wang1212 wang1212 wang1212 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alexzjt @wang1212