Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Nov 13, 2025

Problem

Store the message for later:

                    // check to see if a record request has been sent
                    if let Ok(record) = record_receiver.try_recv() {
                        // remember the record we just received as the next record to occur
                        *next_record = Some(record);
                        break;
                    }

Check service messages because channel is empty (ignoring the stored message):

                if Self::can_process_service_message(&service_message, &record_receiver)
                {
                    break;
                }

The fix is to ensure we don't have a stored message:

                if next_record.is_none()
                    && Self::can_process_service_message(&service_message, &record_receiver)
                {
                    break;
                }

Summary of Changes

  • Add an is_none check to prevent processing service messages when the channel is empty.

Fixes #9002


This is an automatic backport of pull request #9047 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner November 13, 2025 19:35
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (c5001c1) to head (e74afd6).

Additional details and impacted files
@@           Coverage Diff            @@
##             v3.1    #9063    +/-   ##
========================================
  Coverage    83.2%    83.2%            
========================================
  Files         864      864            
  Lines      375253   375331    +78     
========================================
+ Hits       312273   312527   +254     
+ Misses      62980    62804   -176     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@t-nelson
Copy link

@OliverNChalk who's good for sme approval here?

@OliverNChalk
Copy link

Apart from Andrew who's currently OOO, it doesn't seem like anyone has touched this code recently - so I'm not sure from git blame who might be good... I did discuss the bug with @tao-stones so he's probably a good option given no authors around

@t-nelson
Copy link

@AshwinSekar get in here lil shid

Copy link

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as SME

@willhickey willhickey merged commit cae3526 into v3.1 Nov 19, 2025
43 checks passed
@willhickey willhickey deleted the mergify/bp/v3.1/pr-9047 branch November 19, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants