Decople unstaked tps #9288
Decople unstaked tps #9288
Conversation
| /// Max TPS allowed for unstaked connection | ||
| const MAX_UNSTAKED_TPS: u64 = 200; | ||
| /// Expected % of max TPS to be consumed by unstaked connections | ||
| const EXPECTED_UNSTAKED_STREAMS_PERCENT: u64 = 20; |
There was a problem hiding this comment.
Because we are changing its semantics here. It only reduces the TPS allocation for staked connection table (removing 20% from their quota).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9288 +/- ##
=========================================
- Coverage 82.6% 82.6% -0.1%
=========================================
Files 892 892
Lines 321056 321054 -2
=========================================
- Hits 265387 265371 -16
- Misses 55669 55683 +14 🚀 New features to boost your workflow:
|
|
looks good as a first step |
622d0cc to
e382353
Compare
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
decouple unstaked node TPS from overall staked TPS limit (cherry picked from commit 8303e4b)
Decople unstaked tps (#9288) decouple unstaked node TPS from overall staked TPS limit (cherry picked from commit 8303e4b) Co-authored-by: Alex Pyattaev <[email protected]>
decouple unstaked node TPS from overall staked TPS limit
Problem
Unstaked TPS quota is cut away from staked under assumption that unstaked connections consume 100% of their allocated bandwidth at all times. This is generally not happening based on MNB data. Thus, the bandwidth allocation is overkill, preventing us from admitting more staked traffic.
Summary of Changes
max_unstaked_connectionsparameter.This is on top of #9277