Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Pinocchio is using common functionality from the SDK, but still replicated helpers for the
sol_log_*syscalls.Solution
Remove the
logmodule from pinocchio. Programs that require logging should either usesolana-msgor the soon to be createdsolana-program-log.Logging is still used in the custom panic handler implementation – this is replaced by a direct call to
sol_log_syscall.