Cleanup - SBPF version 0x20
#66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49479e3 to
a1ae297
Compare
LucasSte
reviewed
Sep 26, 2025
src/elf.rs
Outdated
|
|
||
| /// Validates the ELF | ||
| pub fn validate(config: &Config, elf: &Elf64, elf_bytes: &[u8]) -> Result<(), ElfError> { | ||
| pub fn validate(_config: &Config, elf: &Elf64, elf_bytes: &[u8]) -> Result<(), ElfError> { |
Collaborator
There was a problem hiding this comment.
What about removing the unused parameter?
LucasSte
reviewed
Sep 26, 2025
src/elf.rs
Outdated
| } | ||
| refd_addr | ||
| } else { | ||
| let refd_addr = { |
Collaborator
There was a problem hiding this comment.
Do we need the brackets here?
…() as that is only used in Executable::load_with_lenient_parser().
…nable_elf_vaddr().
a1ae297 to
ec9fd17
Compare
LucasSte
approved these changes
Sep 29, 2025
src/elf.rs
Outdated
Comment on lines
960
to
961
|
|
||
| if text_section | ||
| .file_range() | ||
| .unwrap_or_default() | ||
| .contains(&r_offset) | ||
| || sbpf_version == SBPFVersion::V0 | ||
| { |
Collaborator
There was a problem hiding this comment.
I don't think the new scope here is necessary. Removing it improves readability. I'm approving the PR, since this shouldn't be a blocker.
mjain-jump
approved these changes
Sep 30, 2025
cmoyes-jump
reviewed
Nov 6, 2025
| } | ||
| let entry_pc = if let Some(entry_pc) = (offset as usize).checked_div(ebpf::INSN_SIZE) { | ||
| if !sbpf_version.static_syscalls() { | ||
| function_registry.unregister_function(ebpf::hash_symbol_name(b"entrypoint")); |
There was a problem hiding this comment.
Sorry, why was this removed? It introduces an unexpected behavioral change when entrypoint is registered multiple times with different PCs. Now, we error out with symbol hash collision, whereas before we would have unregistered.
Lichtso
added a commit
that referenced
this pull request
Nov 6, 2025
Lichtso
added a commit
that referenced
this pull request
Nov 7, 2025
Lichtso
added a commit
that referenced
this pull request
Nov 7, 2025
cmoyes-jump
pushed a commit
to firedancer-io/sbpf
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.