fix vm.due_insn_count subtract overflow when enable_instruction_meter=false #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a corner case.
if config.enable_instruction_meter=false & jit is off,
vm.due_insn_count subtract overflow encoutered at
sbpf/src/interpreter.rs
Line 590 in 946f7d9
that's because we set previous_instruction_meter to 0 when config.enable_instruction_meter is set to false
sbpf/src/vm.rs
Lines 347 to 352 in 946f7d9
I confirmed that it exists in interpreter mode,
but I'm not sure about the behavior in JIT mode (request for review)