msg!: make std optional #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febo
reviewed
Mar 31, 2025
febo
reviewed
Apr 1, 2025
7bda419 to
62b7a9f
Compare
|
Please rebase and then we can land this, thanks for your patience! |
62b7a9f to
c637436
Compare
|
There was a breaking change to |
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Sep 21, 2025
* make std optional in solana-msg * lint * cargo sort
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Sep 24, 2025
* add memo program * use MAX_CPI_ACCOUNTS over MAX_TX_ACCOUNTS * nit * add account info borrowing check * update docstring and comments * use &str over &[u8] * check num_accounts * avoid unnecessary codegen * update doc to use &str over &[u8] * fix doc * seperate lifetime
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Sep 25, 2025
* add memo program * use MAX_CPI_ACCOUNTS over MAX_TX_ACCOUNTS * nit * add account info borrowing check * update docstring and comments * use &str over &[u8] * check num_accounts * avoid unnecessary codegen * update doc to use &str over &[u8] * fix doc * seperate lifetime
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Oct 3, 2025
* add memo program * use MAX_CPI_ACCOUNTS over MAX_TX_ACCOUNTS * nit * add account info borrowing check * update docstring and comments * use &str over &[u8] * check num_accounts * avoid unnecessary codegen * update doc to use &str over &[u8] * fix doc * seperate lifetime
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Oct 18, 2025
* add memo program * use MAX_CPI_ACCOUNTS over MAX_TX_ACCOUNTS * nit * add account info borrowing check * update docstring and comments * use &str over &[u8] * check num_accounts * avoid unnecessary codegen * update doc to use &str over &[u8] * fix doc * seperate lifetime
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Oct 23, 2025
* add memo program * use MAX_CPI_ACCOUNTS over MAX_TX_ACCOUNTS * nit * add account info borrowing check * update docstring and comments * use &str over &[u8] * check num_accounts * avoid unnecessary codegen * update doc to use &str over &[u8] * fix doc * seperate lifetime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a follow-up PR I'd like to move
sol_log_datahere as I noticed it gets used in a few placesNote: this is a breaking change