secp256k1: Deprecate libsecp256k1 from public interface #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
approved these changes
Apr 4, 2025
#### Problem The libsecp256k1 crate used by the secp256k1-program is unmaintained, but its types appear in the public API of the crate, so we can't upgrade or change the library without breaking users. #### Summary of changes Abstract away the usage of libsecp256k1 by introducing new generic functions that simply take in byte arrays.
joncinque
added a commit
to joncinque/solana-sdk
that referenced
this pull request
Apr 4, 2025
#### Problem This is anza-xyz#114, but for secp256r1 instead, removing external types from the public interface. #### Summary of changes This one was a bit more complicated because it uses openssl types, which aren't as straightforward as simple bytes, so it uses bytes encoded in DER as the interface. This seemed like the most standard format from simple web searching, but I'm certainly no expert in this area. There seemed to also be a lot of vecs in the new instruction implementation, which shouldn't be necessary, so I changed those to arrays.
joncinque
added a commit
that referenced
this pull request
Apr 9, 2025
* secp256r1: Deprecate openssl types in public API #### Problem This is #114, but for secp256r1 instead, removing external types from the public interface. #### Summary of changes This one was a bit more complicated because it uses openssl types, which aren't as straightforward as simple bytes, so it uses bytes encoded in DER as the interface. This seemed like the most standard format from simple web searching, but I'm certainly no expert in this area. There seemed to also be a lot of vecs in the new instruction implementation, which shouldn't be necessary, so I changed those to arrays. * Rename variable
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Sep 21, 2025
* secp256r1: Deprecate openssl types in public API #### Problem This is anza-xyz#114, but for secp256r1 instead, removing external types from the public interface. #### Summary of changes This one was a bit more complicated because it uses openssl types, which aren't as straightforward as simple bytes, so it uses bytes encoded in DER as the interface. This seemed like the most standard format from simple web searching, but I'm certainly no expert in this area. There seemed to also be a lot of vecs in the new instruction implementation, which shouldn't be necessary, so I changed those to arrays. * Rename variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The libsecp256k1 crate used by the secp256k1-program is unmaintained, but its types appear in the public API of the crate, so we can't upgrade or change the library without breaking users.
Summary of changes
Abstract away the usage of libsecp256k1 by introducing new generic functions that simply take in byte arrays.