Replace `std::error::Error` with `core::error::Error` #116

divyaranjan1905 · 2025-04-02T05:20:44Z

This PR simply replaces instances of std::error::Error with core::error::Error. It fixes #81, but as mentioned in the issue, it should probably be merged after #115.

Regards,

Divya.

sonicfromnewyoke · 2025-04-02T16:55:52Z

hash/src/lib.rs

    Invalid,
 }

 #[cfg(feature = "std")]


i guess it can be dropped

sonicfromnewyoke · 2025-04-02T16:56:42Z

pubkey/src/lib.rs

    }
 }

 #[cfg(feature = "std")]


the same here

sonicfromnewyoke · 2025-04-02T16:56:48Z

pubkey/src/lib.rs

    }
 }

 #[cfg(feature = "std")]


sonicfromnewyoke · 2025-04-02T16:57:26Z

instruction/src/error.rs

    ArithmeticOverflow,
 }

 #[cfg(feature = "std")]


and this one also

sonicfromnewyoke · 2025-04-02T16:58:12Z

instruction/src/error.rs

    // conversions must also be added
 }

 #[cfg(feature = "std")]


one more place

sonicfromnewyoke · 2025-04-02T17:04:43Z

instruction/src/error.rs

-impl std::error::Error for InstructionError {}
+impl core::error::Error for InstructionError {}

 #[cfg(feature = "std")]


this is also can be omitted, because this is a core::fmt::Dispalay trait

Okay, I originally considered dropping these attributes, but I wasn't sure. Thank you for confirming.

divyaranjan1905 · 2025-04-02T18:30:53Z

Rebased the last few commits and removed the feature attributes for std.

joncinque · 2025-07-08T11:39:03Z

There have been quite a few changes since the PR was first opened, but we should be ready to integrate it -- can you rebase and update your branch? Let me know if you don't have time, and I'll be happy to take this over

divyaranjan1905 · 2025-07-08T11:42:48Z

There have been quite a few changes since the PR was first opened, but we should be ready to integrate it -- can you rebase and update your branch? Let me know if you don't have time, and I'll be happy to take this over

NO worries, will rebase and push by today.

kevinheavey · 2025-07-10T10:11:14Z

Could you please add rust-version = "1.81.0" to the Cargo.toml for every crate using core::error? 🙏

Otherwise the error messages for people on old Rust versions will be confusing

apfitzge · 2025-07-10T14:24:09Z

.github/workflows/main.yml

      - name: Check formatting
        run: ./scripts/check-fmt.sh

-  check:


why is this PR changing CI?

joncinque · 2025-07-21T12:14:36Z

@divyaranjan1905 do you still have time for this? If not I can take over the PR

divyaranjan1905 · 2025-07-21T20:40:49Z

@divyaranjan1905 do you still have time for this? If not I can take over the PR

I tried to rebase, but it didn't resolve nicely. Anything should I be specifically paying attention to? I'll try once again.

joncinque · 2025-07-21T22:15:55Z

There have been a lot of changes since the PR was created, so it would probably be easier to redo it from scratch. It looks like a few merge commits snuck in too, which probably isn't helping

divyaranjan1905 · 2025-07-23T04:24:22Z

@joncinque Would this be required anymore? I was told to remove the std attribute from other places, but I am not sure about this.

solana-sdk/signature/src/error.rs

Line 27 in ec56d76

#[cfg(all(feature = "std", feature = "alloc"))]

joncinque

Looks good overall! Just a few last things to fixup, then we should be good to go

bls-signatures/src/keypair.rs

quic-definitions/src/lib.rs

signature/src/error.rs

signature/src/lib.rs

signature/src/error.rs

joncinque

Just a last bit, then this can go in!

joncinque · 2025-07-24T11:05:19Z

signature/src/lib.rs

 #[cfg(feature = "std")]
-use std::{error::Error, vec::Vec};
+use core::error::Error;
+use std::vec::Vec;


This isn't correct -- the whole point is to only bring in vec if the std feature is enabled:

Suggested change

#[cfg(feature = "std")]

use std::{error::Error, vec::Vec};

use core::error::Error;

use std::vec::Vec;

#[cfg(feature = "std")]

use std::vec::Vec;

use core::error::Error;

joncinque · 2025-07-24T11:05:47Z

signature/src/error.rs

 //! [RustCrypto's opaque signature error](https://github.com/RustCrypto/traits/tree/master/signature)

-#[cfg(all(feature = "std", feature = "alloc"))]
+#[cfg(all(feature = "alloc"))]


nit: for all of these, we don't need all anymore

Suggested change

#[cfg(all(feature = "alloc"))]

#[cfg(feature = "alloc")]

divyaranjan1905 · 2025-07-24T11:34:38Z

That should be it :)

Sorry for the tiny mistakes.

joncinque · 2025-07-24T17:58:15Z

Looks like there are some CI failures:

be sure to run ./cargo nightly fmt --all to format the code
check the test errors by running ./scripts/build-sbf.sh or ./scripts/check-hack.sh

divyaranjan1905 · 2025-07-24T22:57:32Z

Looks like it's still failing. Interesting:
https://github.com/anza-xyz/solana-sdk/actions/runs/16509156545/job/46687480671?pr=116#step:6:659

I have not touched it in my diff though.

divyaranjan1905 · 2025-07-24T23:00:52Z

Changing it to self.source(), I get the following complaint from the compiler:

error[E0599]: the method `as_ref` exists for reference `&&dyn Error`, but its trait bounds were not satisfied  
  --> signature/src/error.rs:85:34  
   |  
85 |             .map(|source| source.as_ref() as &(dyn core::error::Error + 'static))  
   |                                  ^^^^^^  
   |  
   = note: the following trait bounds were not satisfied:  
           `dyn StdError: AsRef<_>`  
           which is required by `&dyn StdError: AsRef<_>`  
           `&dyn StdError: AsRef<_>`  
           which is required by `&&dyn StdError: AsRef<_>`

joncinque · 2025-07-25T09:45:36Z

signature/src/error.rs

        self.source
            .as_ref()
-            .map(|source| source.as_ref() as &(dyn std::error::Error + 'static))
+            .map(|source| source.as_ref() as &(dyn core::error::Error + 'static))


The issue is here -- since source only exists when the alloc feature is enabled, we need to gate this properly:

Suggested change

self.source

.as_ref()

.map(|source| source.as_ref() as &(dyn std::error::Error + 'static))

.map(|source| source.as_ref() as &(dyn core::error::Error + 'static))

#[cfg(feature = "alloc")]

{

self.source.as_ref()

.map(|source| source.as_ref() as &(dyn core::error::Error + 'static))

}

#[cfg(not(feature = "alloc"))]

{

None

}

* Also adds rust-version = "1.81.0" for all such crates * Removes the redundant std attribute

joncinque · 2025-07-28T11:37:22Z

Looks like there's still a formatting issue and a build issue. If you can, please run the commands before committing. And if you don't have time, I can take the PR from here

divyaranjan1905 · 2025-07-28T12:02:36Z

@joncinque The commands somehow don't run on my system. And it's probably my system's issue. But yeah please take the PR from here and make the necessary formatting fixes.

joncinque

Thanks for your contribution! I might need another approval, but let's see if this works...

Edit: I do need another approval

* replace std with core for Error * Also adds rust-version = "1.81.0" for all such crates * Removes the redundant std attribute * Fix CI failures --------- Co-authored-by: Jon C <[email protected]>

divyaranjan1905 requested a review from a team as a code owner April 2, 2025 05:20

joncinque added the breaking PR contains breaking changes label Apr 2, 2025

sonicfromnewyoke reviewed Apr 2, 2025

View reviewed changes

joncinque mentioned this pull request Apr 9, 2025

v3: Tracking issue for upcoming breaking changes #84

Closed

apfitzge reviewed Jul 10, 2025

View reviewed changes

.github/workflows/main.yml Outdated

- name: Check formatting

run: ./scripts/check-fmt.sh

check:

Copy link

Contributor

apfitzge Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this PR changing CI?

divyaranjan1905 force-pushed the master branch from f444473 to c74721b Compare July 23, 2025 04:39

joncinque reviewed Jul 23, 2025

View reviewed changes

divyaranjan1905 force-pushed the master branch from c74721b to 92c06e0 Compare July 24, 2025 05:25

joncinque reviewed Jul 24, 2025

View reviewed changes

divyaranjan1905 force-pushed the master branch from 92c06e0 to 891f89e Compare July 24, 2025 11:34

divyaranjan1905 force-pushed the master branch from 891f89e to a51fcc9 Compare July 24, 2025 22:26

joncinque reviewed Jul 25, 2025

View reviewed changes

replace std with core for Error

a64eac7

* Also adds rust-version = "1.81.0" for all such crates * Removes the redundant std attribute

divyaranjan1905 force-pushed the master branch from a51fcc9 to a64eac7 Compare July 28, 2025 05:40

Fix CI failures

d529a54

joncinque approved these changes Jul 28, 2025

View reviewed changes

joncinque requested a review from apfitzge July 28, 2025 12:42

apfitzge approved these changes Jul 28, 2025

View reviewed changes

joncinque merged commit 7497283 into anza-xyz:master Jul 28, 2025
25 checks passed

Uh oh!

Replace std::error::Error with core::error::Error #116

Replace std::error::Error with core::error::Error #116

Uh oh!

Conversation

divyaranjan1905 commented Apr 2, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

divyaranjan1905 commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joncinque commented Jul 8, 2025

Uh oh!

divyaranjan1905 commented Jul 8, 2025

Uh oh!

kevinheavey commented Jul 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joncinque commented Jul 21, 2025

Uh oh!

divyaranjan1905 commented Jul 21, 2025

Uh oh!

joncinque commented Jul 21, 2025

Uh oh!

divyaranjan1905 commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joncinque left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joncinque left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

divyaranjan1905 commented Jul 24, 2025

Uh oh!

joncinque commented Jul 24, 2025

Uh oh!

divyaranjan1905 commented Jul 24, 2025

Uh oh!

divyaranjan1905 commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joncinque commented Jul 28, 2025

Uh oh!

divyaranjan1905 commented Jul 28, 2025

Uh oh!

joncinque left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Replace `std::error::Error` with `core::error::Error` #116

Replace `std::error::Error` with `core::error::Error` #116

divyaranjan1905 commented Apr 2, 2025 •

edited

Loading

divyaranjan1905 commented Jul 23, 2025 •

edited

Loading

divyaranjan1905 commented Jul 24, 2025 •

edited

Loading

joncinque left a comment •

edited

Loading