program-error!: Improve ToStr ergonomics #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#191 will address the CI failure |
febo
reviewed
Jun 6, 2025
| pub trait ToStr { | ||
| fn to_str<E>(&self) -> &'static str | ||
| where | ||
| E: 'static + ToStr + TryFrom<u32>; |
Is requiring fewer bounds a breaking change? |
Ah, it is on the |
#### Problem The `ToStr` trait is a bit difficult to use, forcing a lot of redundant uses of types, when programs will just want to call `err.to_str::<MyError>()`. #### Summary of changes Simplify the trait to not require anything, then add a generic `to_str` function directly on `ProgramError` that allows us to get the error message for a particular error type. Also, clarify the deprecation warning on `DecodeError`. BREAKING CHANGE: the `ToStr` trait requires fewer bounds
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Sep 21, 2025
#### Problem The `ToStr` trait is a bit difficult to use, forcing a lot of redundant uses of types, when programs will just want to call `err.to_str::<MyError>()`. #### Summary of changes Simplify the trait to not require anything, then add a generic `to_str` function directly on `ProgramError` that allows us to get the error message for a particular error type. Also, clarify the deprecation warning on `DecodeError`. BREAKING CHANGE: the `ToStr` trait requires fewer bounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
ToStrtrait is a bit difficult to use, forcing a lot of redundant uses of types, when programs will just want to callerr.to_str::<MyError>().Summary of changes
Simplify the trait to not require anything, then add a generic
to_strfunction directly onProgramErrorthat allows us to get the error message for a particular error type.Also, clarify the deprecation warning on
DecodeError.BREAKING CHANGE: the
ToStrtrait requires fewer bounds