{instruction,program}error!: remove unused std features #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
reviewed
Jul 31, 2025
| use solana_frozen_abi_macro::{AbiEnumVisitor, AbiExample}; | ||
| #[cfg(feature = "std")] | ||
| #[cfg(feature = "frozen-abi")] | ||
| extern crate std; |
There was a problem hiding this comment.
will this be confusing since std is included even without a std feature?
i guess my expectation for a no-std crate is that it doesn't use std unless you pass std feature.
There was a problem hiding this comment.
frozen-abi doesn't count imo, if someone pulls that in they have other problems
There was a problem hiding this comment.
I'd agree with that -- the frozen-abi feature is only used for a specific test build, and the macros happen to require std, so we have to pull in std somehow.
apfitzge
approved these changes
Aug 4, 2025
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Sep 21, 2025
* remove unused std features * fmt * add extern crate std under frozen-abi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instruction-error and program-error crates have
stdfeatures in Cargo.toml that don't do anything