[bn254] Refactor out addition, multiplication, and pairing into separate modules #290
+470
−383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e916e91 to
e3401d6
Compare
e3401d6 to
e1d0e72
Compare
|
What do you think about moving |
Okay, this should be updated. |
|
It is also in |
96388b3 to
b2d5970
Compare
LucasSte
approved these changes
Aug 26, 2025
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Sep 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The logic in
lib.rsis becoming slightly harder to read as it is getting longer and it is organized by submodules inside files.Summary of Changes
I created logical submodules for the
addition,multiplication, andpairingoperations for elliptic curves. I then moved the relevant logic inlib.rsto these relevant submodules. All the functions and constants inlib.rswere behind private submodules (constsandtarget_arch) and were re-exported as part ofprelude. I kept this structure the same, so from the perspective of downstream projects, this should not introduce any visible changes.