vote-interface: drop all vote-program-specific methods #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38947f0 to
141c7d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the ongoing work to overhaul the vote state processing in the vote program, we've decided to move all of the functionality that's currently represented in the public API for
VoteStateVersionsandVoteStateV3into the vote program itself.This will be a major breaking change, as it removes all methods from
VoteStateVersionsandVoteStateV3that are really only necessary for the Vote program.I've done each method one at a time, and I've also removed any tests that were only testing that method itself. These tests have been moved to the Vote program.