allow with_seed functions to accept any bytes, not just UTF-8 #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i don't think there is any rationale for enforcing utf8 here
yes. during adoption of the change, upgraded vs not nodes would have differing execution results for non-utf8 inputs |
|
Pre-SIMD discussion here solana-foundation/solana-improvement-documents#378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
with_seedfunctions (egAddress::create_with_seed) andWithSeedinstruction variants (egSystemInstruction::CreateAccountWithSeed) all expect&strorString. But they don't do anything that requires UTF-8, and they just convert these values back to bytes.Two reasons this is bad:
Address) as a seedBreaking changes:
Address::create_with_seedis technically a breaking change. Changing the type to&(impl AsRef<[u8]> + ?Sized),means it works as before for most people, but breaks for anyone passingcreate_with_seeditself to a function that expected theseedparam to be&str. It's possible that nobody is doing this.&[u8]orVec<u8>In Agave there would be some small changes to system_processor.rs and vote_processor.rs. Firedancer would need to remove the UTF-8 check. Does this need a SIMD?