refactor: bls_signatures: use iterators instead of slices in various APIs
#371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
approved these changes
Oct 12, 2025
There was a problem hiding this comment.
Thanks! These are nice changes. You can consider rewording the commit message, but other than that, looks fine.
We do currently use slices throughout the crate, so we can consider updating those for consistency and better API. I can probably take a stab at those in a follow-up.
This was referenced Oct 12, 2025
akhi3030
added a commit
that referenced
this pull request
Oct 13, 2025
Similar to #371, changes `&[&PublicKey]` to `&[Pubkey]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of iterators allows the caller to use the API without having to
collect()the items first.This will help in eliminating a
collect()here.