BREAKING: human readable de/ser for versioned message #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0d108f to
29ad202
Compare
|
@jstarry can you add a description to the PR? |
apfitzge
approved these changes
Oct 15, 2025
|
Thanks for the review @apfitzge! Sorry I was in the middle of updating the description but got side tracked while looking into another human readable serialization issue. EDIT: Just conservatively marked this as breaking because my other change will definitely breaking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versioned messages are not properly supported for human readable de/ser due to special handling of the version prefix byte. This is a breaking change to how versioned messages (including v0 and legacy) are serialized and deserialized when using a human readable serialization format. More context about the consequences of this lack of support can be found in #311
Old serialization:
New serialization:
{ "version": "0", "message": { "header": { "numRequiredSignatures": 0, "numReadonlySignedAccounts": 0, "numReadonlyUnsignedAccounts": 0 }, "accountKeys": [..] "recentBlockhash": [..], [..] } }