Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Relax] Remove duplicated test case: test_if_branch_var_scope#18613

Merged
mshr-h merged 1 commit intoapache:mainfrom
cchung100m:remove_duplicated_test_case
Dec 31, 2025
Merged

[Relax] Remove duplicated test case: test_if_branch_var_scope#18613
mshr-h merged 1 commit intoapache:mainfrom
cchung100m:remove_duplicated_test_case

Conversation

@cchung100m
Copy link
Contributor

@cchung100m cchung100m commented Dec 26, 2025

Hi Commiters,

This PR is trying to remove duplicated test case test_if_branch_var_scope. Any suggestions would be appreciated if you are available.

Root Cause

Both tests test_var_if_scoping_fail and test_if_branch_var_scope verify that returning a variable w that's only defined within if/else branches raises an error. They're duplicates and should probably be consolidated into a single test.

image

Solution

Remove duplicated test case test_if_branch_var_scope

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 26, 2025

Summary of Changes

Hello @cchung100m, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the test suite by eliminating a redundant test case. It specifically targets and removes test_if_branch_var_scope, which was found to be a duplicate of test_var_if_scoping_fail. Both tests validate the expected error when a variable defined solely within conditional branches is returned, ensuring that the test coverage remains intact while reducing unnecessary code and improving maintainability.

Highlights

  • Test Case Removal: The test_if_branch_var_scope test case has been removed from tests/python/relax/test_tvmscript_parser.py.
  • Test Consolidation: This removal addresses a duplication, as its functionality is already covered by the test_var_if_scoping_fail test, both verifying variable scoping rules within if/else branches.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 26, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the duplicated test case test_if_branch_var_scope, which is functionally identical to test_var_if_scoping_fail. This is a good code cleanup that improves the maintainability of the test suite. The change is correct and I have no further suggestions.

@cchung100m cchung100m marked this pull request as ready for review December 26, 2025 07:42
@cchung100m
Copy link
Contributor Author

cchung100m commented Dec 30, 2025

Hi @tlopex @mshr-h

Any suggestions would be appreciated if you are available. 😄

@mshr-h mshr-h merged commit 5abc5c7 into apache:main Dec 31, 2025
11 checks passed
@cchung100m
Copy link
Contributor Author

cchung100m commented Dec 31, 2025

Thanks to @mshr-h and happy new year! 😄

@cchung100m cchung100m deleted the remove_duplicated_test_case branch December 31, 2025 12:12
@ysh329 ysh329 mentioned this pull request Feb 1, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshr-h mshr-h mshr-h approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cchung100m @mshr-h