Syntax error fix for default filter #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'll have a look at the duplication |
|
Fixed in 64da8ab |
paulrutter
pushed a commit
that referenced
this pull request
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the default filter I get the following Exception:
jakarta.servlet.ServletException: org.osgi.framework.InvalidSyntaxException: Only one top-level operation allowed: (&(objectClass=jakarta.servlet.http.HttpServlet)((http.felix.dispatcher=*)(objectClass=jakarta.servlet.http.HttpServlet))) org.apache.felix.http.proxy.AbstractProxyServlet.service(AbstractProxyServlet.java:113) jakarta.servlet.http.HttpServlet.service(HttpServlet.java:716) org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51) org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:483) org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93) org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:663) org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342) org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:395) org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63) org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:905) org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1746) org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52) org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1148) org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636) org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:63) java.base/java.lang.Thread.run(Thread.java:1583)The LDAP syntax is not correct here.
By the way, I'm a bit surprised about the query why querying for the objectClass is done twice:
(&(objectClass=jakarta.servlet.http.HttpServlet)((http.felix.dispatcher=*)(objectClass=jakarta.servlet.http.HttpServlet)))Shouldn't be
(&(http.felix.dispatcher=*)(objectClass=jakarta.servlet.http.HttpServlet))enough if no filter is available?