[FLINK-30989][runtime] Some config options related to sorting and spilling are not valid. #22002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
For some config options like
taskmanager.runtime.sort-spilling-threshold,taskmanager.runtime.max-fan... etc. used for sorting and spilling, we get this option value from JobConfiguration. In fact, these parameters should be only available in theTaskManagerConfigurationnow. The current change is to think of them as cluster-level configurations. The reason is that from the key of these Option, they are all prefixed with taskmanager.I'm not sure whether consider this as job-wise conf is better.
Brief change log
TaskManagerConfigurationto load these config options.Verifying this change
Manual testing.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation