Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@reswqa
Copy link
Member

@reswqa reswqa commented Feb 23, 2023

What is the purpose of the change

For some config options like taskmanager.runtime.sort-spilling-threshold ,taskmanager.runtime.max-fan ... etc. used for sorting and spilling, we get this option value from JobConfiguration. In fact, these parameters should be only available in the TaskManagerConfiguration now. The current change is to think of them as cluster-level configurations. The reason is that from the key of these Option, they are all prefixed with taskmanager.
I'm not sure whether consider this as job-wise conf is better.

Brief change log

  • Using TaskManagerConfiguration to load these config options.

Verifying this change

Manual testing.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 23, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@reswqa reswqa force-pushed the FLINK-30989-job-conf branch from b54aa98 to f91db2c Compare April 4, 2023 09:48
@reswqa
Copy link
Member Author

reswqa commented Apr 4, 2023

Because this PR has been going on for a long time, I have rebased on master and re-pushed it to re-run CI for safety's sake.

@reswqa reswqa closed this in ccd0fe2 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants