You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 30, 2023. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced com.google.code.findbugs:annotations:2.0.2 with com.github.stephenc.findbugs:findbugs-annotations:1.3.9-1 and com.google.code.findbugs:jsr305:2.0.2.
Had to remove a couple annotations that don't exist in the older version of the drop-in replacement. There is a newer version of com.github.stephenc.findbugs:findbugs-annotations, but it hasn't been uploaded to maven central for some reason. Moved usage of those annotations to the findbugs-exclude.xml file.
FindBugs is BSD, there's been some threads in other places indicating this is true based on the LICENSE file, but the maven package was built incorrectly.
I did come across this thread [1], which discusses that com.google.code.findbugs:jsr305 is BSD, and documents that the JSR-305's BSD license is included in the findbugs repo [2]. But the license for FindBugs source is LGPL [3].
Unfortunately, Giraph is using com.google.code.findbugs:annotations which includes both JSR-305 and some FindBugs annotations [4], [5] which do have LGPL headers in the source listings.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
com.google.code.findbugs:annotations:2.0.2withcom.github.stephenc.findbugs:findbugs-annotations:1.3.9-1andcom.google.code.findbugs:jsr305:2.0.2.Had to remove a couple annotations that don't exist in the older version of the drop-in replacement. There is a newer version of com.github.stephenc.findbugs:findbugs-annotations, but it hasn't been uploaded to maven central for some reason. Moved usage of those annotations to the findbugs-exclude.xml file.