This repository was archived by the owner on Oct 30, 2023. It is now read-only.
Fixing MemoryEstimatorOracle #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Once the OOC is at OFFLAODING state, it may offload data to disk indefinitely. We should call GC manually and get OOC out of OFFLOADING if anything has changed in computation/communication pattern. Fixes a "if" statement which entirely disabled regression for memory estimation. * Interleaving of in resetting and calculating memory estimation potentially can cause data race. * The superstep count in memory estimator was not coherent throughout the calculation. * Sometime the memory estimator's accuracy is not good. We should fall back to a threshold-based scheme relying on a more pessimistic memory usage report (such as the one given by JVM – memory usage includes garbage data too, but it can be used as a pessimistic estimate, as it is currently used in ThresholdBasedOracle). More tuning is needed for a smooth memory estimation mechanism. "mvn clean install" passes all tests and checks.
88368a2 to
a7ab3ce
Compare
dlogothetis
reviewed
Oct 4, 2017
|
|
||
| @Override | ||
| public boolean approve(IOCommand command) { | ||
| if (!(command instanceof WaitIOCommand) && |
There was a problem hiding this comment.
Can you add some documentation for the logic here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff contains the following fixes:
"mvn clean install" passes all tests and checks.