-
Couldn't load subscription status.
- Fork 9.1k
YARN-11262. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-resourcemanager Part6. #7490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
π -1 overall
This message was automatically generated. |
|
π -1 overall
This message was automatically generated. |
ab6cc83 to
42c114f
Compare
|
π -1 overall
This message was automatically generated. |
|
π -1 overall
This message was automatically generated. |
|
π -1 overall
This message was automatically generated. |
|
π -1 overall
This message was automatically generated. |
|
π -1 overall
This message was automatically generated. |
|
π -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. It's your choice if you want to fix more whitespace and checkstyle warnings, but I don't think it's a blocker. Thank you, @slfan1989 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1,LGTM @slfan1989
@cnauroth Thank you very much for reviewing the code! I have fixed the issues with the checkstyle, and this is the final upgrade PR for the ResourceManager module. We will soon complete the upgrade for this module. Currently, there are two remaining modules to be upgraded in yarn. The timelineservice-hbase-tests (#7538) is almost ready, and I will start the upgrade for yarn-router as soon as possible. |
|
π +1 overall
This message was automatically generated. |
|
π +1 overall
This message was automatically generated. |
|
π +1 overall
This message was automatically generated. |
|
π +1 overall
This message was automatically generated. |
Description of PR
JIRA: YARN-11262. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-resourcemanager Part6.
How was this patch tested?
Junit test & mvn clean test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?